This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for Review: Build all libjava .class files at once


Hi Tom,

Thanks for having a look at this.

>Mohan> +built_java_class_files: build_java_sources_init $(all_java_class_files)
>
>Unfortunately this approach doesn't work when doing a parallel
>make -- ordering the dependencies is insufficient.

I was actually wondering about parallel makes. Thanks for pointing this out. I'll try
what you suggested.

>Mohan> +	@if test -s $(tmp_java_filelist); then echo Compiling Java sources....; \
>Mohan> +	    $(JAVAC) $(JCFLAGS) -classpath '' -bootclasspath $(here):$(srcdir) \
>Mohan> +	    -d $(here) @$(tmp_java_filelist); \
>Mohan> +	fi
>
>I'd rather see the command line here.  That makes it a bit easier to
>debug when/if gcj crashes...

I'll do this, but can you explain a bit more what you mean by this? How will things be easier
to debug?

>What does gcj do if the @-file is empty?

I'll look into this. If it does the wrong thing, it should hopefully be easy to fix....

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]