This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for Review: Build all libjava .class files at once


>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:

Mohan> On my PII 450MHz/256MB machine running RH 8.0, this patch cuts
Mohan> the time for this step down to roughly four and a half minutes
Mohan> compared to a pre-patch time of roughly 12.5 minutes.

Nice.

Mohan> +built_java_class_files: build_java_sources_init $(all_java_class_files)

Unfortunately this approach doesn't work when doing a parallel
make -- ordering the dependencies is insufficient.

Try something like:

built_java_class_files:
	-@rm -f $(tmp_java_filelist)
	@touch $(tmp_java_filelist)
        $(MAKE) really_build_class files

really_build_class_files: $(all_java_class_files)


Also:

Mohan> +	@if test -s $(tmp_java_filelist); then echo Compiling Java sources....; \
Mohan> +	    $(JAVAC) $(JCFLAGS) -classpath '' -bootclasspath $(here):$(srcdir) \
Mohan> +	    -d $(here) @$(tmp_java_filelist); \
Mohan> +	fi

I'd rather see the command line here.  That makes it a bit easier to
debug when/if gcj crashes...

What does gcj do if the @-file is empty?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]