Re: RFC: Moving native code in java.net into architecture dependant files - updated patch

[Mohan Embar <gnustuff at thisiscool dot com>]

Hi Michael,

This looks nice. I've got a couple of comments, though:

- Here, you seem to want to disable the net code if we are doing a non-native build:

       GCJ="${target_alias}-gcj"
    fi
    NATIVE=no
+   PLATFORMNET=NoNet
 else
    AC_CHECK_FUNCS(strerror ioctl select fstat open fsync sleep opendir)

    However, I don't think this is necessary. We are using the cross compiler to build a library
    that is intended for consumption on the target platform, so we presumably have everything
    in place needed to do this. The library we're building isn't intended to run on the host platform.

- Given that Tom said that we will need to continue supporting net-less code:

  http://gcc.gnu.org/ml/java-patches/2003-q1/msg00788.html

  ...I think we would need a line in configure.in that looks something like this:

  if test "$enable_java_net" = no; then
     PLATFORMNET=NoNet
  fi

  This would disable the net code regardless of platform if they chose --disable-java-net.

  This would presumably come right before this line:

  +AC_LINK_FILES(java/net/natInetAddress${PLATFORMNET}.cc, java/lang/natInetAddress.cc)

  or else right after this case statement:

  case "$TARGET_ECOS" in
  ...
  esac

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/