This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Outstanding patches
- From: "Ranjit Mathew" <rmathew4lists at hotmail dot com>
- To: <java-patches at gcc dot gnu dot org>
- Date: Fri, 7 Mar 2003 16:43:29 +0530
- Subject: Re: Outstanding patches
- References: <15976.30370.141842.752106@cuddles.cambridge.redhat.com>
- Reply-to: "Ranjit Mathew" <rmathew at hotmail dot com>
> I might have some time this weekend to look at outstanding patches.
>
> Please remind me of any patches that want attention.
That would be very nice of you. I have the following for your
review, if possible:
http://gcc.gnu.org/ml/java-patches/2003-q1/msg00541.html
http://gcc.gnu.org/ml/java/2003-02/msg00266.html
In addition, I noticed that the following is desirable:
Index: ChangeLog
from Ranjit Mathew <rmathew at hotmail dot com>
* jcf-parse.c (set_source_filename): Use COMPARE_FILENAMES
instead of strcmp to compare file names.
Use IS_DIR_SEPARATOR instead of directly comparing to
'/' and '\\'.
* jcf-write.c (generate_classfile): Use IS_DIR_SEPARATOR
instead of directly comparing to '/' and '\\'.
Index: jcf-parse.c
===================================================================
--- jcf-parse.c Fri Mar 7 16:28:55 2003
+++ jcf-parse.c Fri Mar 7 16:30:57 2003
@@ -139,7 +139,6 @@
if it has a directory prefix, but otherwise matches sfname. */
if (old_len > new_len
- && strcmp (sfname, input_filename + old_len - new_len) == 0
- && (input_filename[old_len - new_len - 1] == '/'
- || input_filename[old_len - new_len - 1] == '\\'))
+ && COMPARE_FILENAMES (sfname, input_filename + old_len - new_len) == 0
+ && IS_DIR_SEPARATOR (input_filename[old_len - new_len - 1]))
return;
}
Index: jcf-write.c
===================================================================
--- jcf-write.c Fri Mar 7 16:32:57 2003
+++ jcf-write.c Fri Mar 7 16:33:32 2003
@@ -3094,5 +3094,5 @@
if (ch == '\0')
break;
- if (ch == '/' || ch == '\\')
+ if (IS_DIR_SEPARATOR (ch))
source_file = s+1;
}