This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH: java.security improvements
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Tom Tromey wrote:
> >>>>>"Casey" == Casey Marshall writes:
>
>
> Casey> There is also a fix for a bias in the `next(int numBits)'
> Casey> method of SecureRandom (filed as PR 9271).
>
> This part is small enough to go in before the paperwork for the rest
> is done. So I extracted it. I also rewrote a tiny piece of it. What
> do you think of the appended?
>
> I made two changes: we now compute the return mask more efficiently,
> and also we take into account that `<<' has higher precedence than
> `&'.
>
> If you think this looks ok, I will check it in (to 3.3, 3.4, and
> Classpath).
Looks ok.
> BTW, parts of the patch need reformatting to fit the classpath/libgcj
> coding standard. Could you do that? That will make it easier to put
> the patch in when the time comes.
>
Ok. I assume you mean the indentation of code blocks?
- --
Casey Marshall || rsdio@metastatic.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQE+S0x0gAuWMgRGsWsRAv6DAJ4pVMCHJYLeQK+gUXf6bqbJBgpcUACgjGwt
Y/7VFO0FvAvzGBFVhGgWkRw=
=8rS5
-----END PGP SIGNATURE-----