This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: java.awt - documentation and others - REVISED

>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> Here a better version of the patch.

This looks good to me, though see the comments below first.  Please
check it in: cvs trunk, 3.3, and Classpath (especially the latter
since Classpath is the master source for AWT).  I can do this if you
like.

Michael> -    */    
Michael>      graphicsConfiguration = gc;

This line needs to be reindented.

Michael> +        bits_sum += bits [i];

I think it is clearer to use `|=' here.
Also it avoids any potential overflow problems.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]