This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Java: fixes for -fno-assume-compiled


Tom Tromey writes:
 > >>>>> "Jeff" == Jeff Sturm <jsturm@one-point.com> writes:
 > 
 > I don't really have a problem with this patch.
 > 
 > Jeff> +  // If superclass looks like a constant pool entry,
 > Jeff> +  // resolve it now.
 > Jeff> +  if ((int) klass->superclass < pool->size)
 > Jeff> +    klass->superclass = pool->data[(int) klass->superclass].clazz;
 > 
 > Yuck.
 > Both sides of the comparison should be unsigned, shouldn't they?

This shouldn't be int, but 
  typedef unsigned int  uaddr __attribute__ ((mode (pointer)));

 > Could we add a flag somewhere instead?

I guess this would be better.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]