Re: some InetAddress and URL and more fixes

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> Another patch. Please review and comment.

Sorry for the delay.
This patch is fine.  There are one or two nits though.

Michael> +    // Any class derived from InetAddress should overwrite this.
Michael> +    return addr == zeros;

Say "override", not "overwrite".  There are a couple of these.

Michael> +    return (addr [0] == 0xE0) &&
Michael> +           (addr [1] == 0x00) &&
Michael> +           (addr [2] == 0x00);

Here the parens aren't needed, and the formatting doesn't conform to
the standards.  Write:

  return (addr[0] == 0xE0
          && addr[1] == 0x00
          && addr[2] == 0x00);

That is: no space before `[', no redundant parens (unless required to
make indentation work in Emacs -- a weird requirement, I'll admit),
and `&&' goes after the newline, not before.

There are a few places in the patch with a space before `['. 

Thanks yet again for your work here.

Tom