This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR 5902: Parse errors

Eric> Then there is a bug in gcj -C.  The expression ((019f == 19) ? 0
Eric> : 1) is a compile-time constant, and should be inlined to 0.  I
Eric> don't see where any dead code could feasably arise.

Yeah.  This is a known weak area for gcj :-(.  It doesn't really
handle compile-time constants correctly.  If you run Jacks you can see
there are tons of failures caused by this.

Eric> I think a compiler test is adequate - the PR was not that the
Eric> compiler was using the wrong value, but that it wasn't even
Eric> parsing the original.

Thanks.

Eric> Is the patch below appropriate?

Yeah, thanks.

Eric> OK, I'll fix my previous ChangeLog entries when I commit the new
Eric> versions.

Don't worry about that.  As a rule I never change old ChangeLog
entries.  It feels like rewriting history.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]