This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PR 5902: Parse errors
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- To: Eric Blake <ebb9 at email dot byu dot edu>
- Cc: java-patches at gcc dot gnu dot org
- Date: Mon, 11 Mar 2002 08:32:38 -0800 (PST)
- Subject: Re: PR 5902: Parse errors
- References: <3C8C1627.88A8D341@email.byu.edu>
- Reply-to: apbianco at redhat dot com
Eric Blake writes:
Thank you for looking into this.
> OK to commit mainline and branch?
I think you should separate fixing the comments and fixing the
PR. Sometimes it's OK to change one or two things related to formating
and/or coding convention compliance (and I certainly abused that
rule), but for this particular case, the fix looks a bit lost.
> - /* {E,e} must have seen at list a digit */
> + /* {E,e} must have seen at list a digit. */
While you're at it, ^list^least^
I wanted to give it a little more testing, but the patch appears to be
malformed (first line 11, then 28... probably a paste that went
wrong.) Could you please re-post something? Two different patches
would be really convenient.
Thanks!
./A