This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch: core protocol take 2


>>>>> "Anthony" == Anthony Green <green@redhat.com> writes:

>> Is this code really needed?  I think we can just access the core
>> handler via the Class.forName code after this `if' -- that is, only
>> the file handler needs a special case.

Anthony> BTW - perhaps we should also add
Anthony>     -Wl,-u,_ZN3gnu3gcj8protocol4core7Handler6class$E
Anthony> to libgcj.spec so that we always force it in.  I think the
Anthony> core protocol is cool for embedded systems, but I forsee
Anthony> confusion if we rely on Class.forName and don't force the
Anthony> protocol handler into the link.

If we're going to always force it in then we might as well keep the
check just like we do for the "file" protocol.  I guess the real
question is whether there is a scenario where we'd like to omit this
code.

Anthony> Ok with these changes?

Yes, thanks.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]