Re: Possible Bugs in cgraphunit.c

[Martin Liška <mliska at suse dot cz>]

On 12/5/19 5:08 PM, Nicholas Krause wrote:
> On 12/5/19 7:08 AM, Martin Liška wrote:
> > On 12/5/19 9:00 AM, Nicholas Krause wrote:
> > > Greetings,
> > > Seems that the extend_trucks return values are not returned when called in both,
> > > cnode::assemble_thunks_and_aliases and cnode::create_wrapper. I'm not sure
> > > if this is a set of edge case bugs or there was a reason for this. Seems not as its
> > > checked in the third function caller in the file, cgraph_node::analyze.
> >
> > Hello.
> >
> > You are right that the return value of expand_thunk is not checked (except one place).
> > The code is quite old, so I guess it's not causing issues.
> >
> > Martin
> Indeed or the edge cases are almost never hit or not at all.

There is one usage of the return value.

> So the question is should
> we just change the function to return void as its always successful or fix up the callers?

I would leave it as is.
Martin

> Nick
> > > Not sure if my assumptions are correct so I'm asking if there isn't another reason
> > > for this as the code seems to have at least directly no reason for it,
> > >
> > > Nick