This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Possible Bugs in cgraphunit.c
- From: Martin Liška <mliska at suse dot cz>
- To: Nicholas Krause <xerofoify at gmail dot com>, gcc Mailing List <gcc at gcc dot gnu dot org>
- Date: Thu, 5 Dec 2019 13:08:51 +0100
- Subject: Re: Possible Bugs in cgraphunit.c
- References: <39c77161-074b-c424-af0a-a17351658622@gmail.com>
On 12/5/19 9:00 AM, Nicholas Krause wrote:
Greetings,
Seems that the extend_trucks return values are not returned when called in both,
cnode::assemble_thunks_and_aliases and cnode::create_wrapper. I'm not sure
if this is a set of edge case bugs or there was a reason for this. Seems not as its
checked in the third function caller in the file, cgraph_node::analyze.
Hello.
You are right that the return value of expand_thunk is not checked (except one place).
The code is quite old, so I guess it's not causing issues.
Martin
Not sure if my assumptions are correct so I'm asking if there isn't another reason
for this as the code seems to have at least directly no reason for it,
Nick