This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: ISL tiling question (gcc.dg/graphite/interchange-3.c)
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Steve Ellcey <sellcey at marvell dot com>
- Cc: "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Mon, 14 Jan 2019 09:46:04 +0100
- Subject: Re: ISL tiling question (gcc.dg/graphite/interchange-3.c)
- References: <9c719d1502ed4caedd8155873da31f25b6ce6541.camel@marvell.com>
On Fri, Jan 11, 2019 at 9:02 PM Steve Ellcey <sellcey@marvell.com> wrote:
>
> Someone here was asking about GCC, ISL, and tiling and we looked at
> the test gcc.dg/graphite/interchange-3.c on Aarch64. When this
> test is run the graphite pass output file contains the string 'not
> tiled' and since the dg-final scan-tree-dump is just looking for
> the string 'tiled', it matches and the test passes.
>
> Is this intentional? It seems like if we wanted to check that it was
> not tiled we sould grep for 'not tiled', not just 'tiled'. If we
> want grep to see that it is tiled, then the check for tiling happening
> is wrong.
;)
I _think_ the testcases got annotated with "tiled" a lot and really
meant to test whether tiling would be possible (interchange tests
should check for interchange only).
I think this is probably not intentional but unless you want extra
FAILs I suggest to leave this alone...
Richard.
> Steve Ellcey
> sellcey@marvell.com
>