This is the mail archive of the
mailing list for the GCC project.
Re: Moving to git
- From: Jason Merrill <jason at redhat dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>, David Malcolm <dmalcolm at redhat dot com>
- Cc: "gcc at gnu dot org" <gcc at gnu dot org>
- Date: Thu, 20 Aug 2015 18:37:43 -0400
- Subject: Re: Moving to git
- Authentication-results: sourceware.org; auth=none
- References: <55D61512 dot 8010002 at redhat dot com> <1440099112 dot 18943 dot 38 dot camel at surprise> <20150820223226 dot GA27127 at gate dot crashing dot org>
On 08/20/2015 06:32 PM, Segher Boessenkool wrote:
On Thu, Aug 20, 2015 at 03:31:52PM -0400, David Malcolm wrote:
If we're going to migrate to git (I hope so), can we also please
*slightly* revise the policy on commit messages, to add meaningful
titles to commits?
"The log message for that checkin should be the complete ChangeLog entry
for the change."
and the subsection "Commit the changes to the central repository" below
has an example showing this.
In the git world, the first line of the commit message has special
meaning, being treated as the "title" of the commit.
It would be nice if we could use a real commit message, not just a short
title line; for example, people who prepare their patches in git already
have that, and use it with format-patch as you say.
I think that's what David was suggesting; a short title line, followed
by a blank line, followed by a more substantive commit message.
This change doesn't need to be tied to the git transition; it could
happen either before or after.
And many bonus points
if we don't have to repeat the changelog in the commit message (it's in
the commit already, the bugzilla hook could just pull it from out there).
Or we could have another discussion about if we want to have changelogs
That's a good question, but I think it's definitely independent.