This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).

From: Thomas Schwinge <thomas at codesourcery dot com>
To: Aditya K <hiraditya at msn dot com>
Cc: Richard Biener <richard dot guenther at gmail dot com>, Trevor Saunders <tbsaunde at tbsaunde dot org>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>, Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>
Date: Tue, 31 Mar 2015 09:09:24 +0200
Subject: RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
Authentication-results: sourceware.org; auth=none
References: <BLU179-W40C136025D7BD569ABEE24B61B0 at phx dot gbl>,<CABu31nMN2KajAC4LO=RBrmxG9gHapMJmWbBC=8i_i9RyieZ5pA at mail dot gmail dot com>,<CAFiYyc3uGtRxXN_bdTSHNeBTCX41JnNT3SYs2CAyYXs0_2sR5g at mail dot gmail dot com>,<BLU179-W86E1C1E984B9AE31FCC5DBB6070 at phx dot gbl>,<CAH6eHdRWUfuVEac-4aZTayBCr5BmbzELNPEz62-FNpr44ihksw at mail dot gmail dot com>,<BLU179-W229A566D6DBF2668CBB6ACB6070 at phx dot gbl>,<20150315060335 dot GA17414 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com>,<BLU179-W61338647FCB5BE476609FB6020 at phx dot gbl>,<CAFiYyc3tbBRUT2Jof5qDi=aeL7Zy4hcb5DQoHa6CwJ9_FAS0PA at mail dot gmail dot com>,<BLU179-W3054B2B4026817EFC4905FB6000 at phx dot gbl>,<CAAgBjMnVSVKyqJPGgoOU+S4+9TshGOF437SY4-V40Sfg2vbVFw at mail dot gmail dot com>,<BLU179-W42AEA9571B2BBACC60C833B6000 at phx dot gbl> <BLU179-W22D3FE4AD8EBBA423B62F8B6F50 at phx dot gbl>

Hi!

On Mon, 30 Mar 2015 22:28:41 +0000, Aditya K <hiraditya@msn.com> wrote:
> So I have modified the patch to use hash_map instead of std::map. The patch is attached.
> 
> However, I got one regression after that.
> 
> # Comparing directories
> ## Dir1=../build-pristine/: 11 sum files
> ## Dir2=../build-test/: 11 sum files
> 
> # Comparing 11 common sum files
> ## /bin/sh ../contrib/compare_tests Â/tmp/gxx-sum1.29214 /tmp/gxx-sum2.29214
> Tests that now fail, but worked before:
> 
> c-c++-common/goacc/loop-private-1.c Â-std=c++98 Âscan-tree-dump-times gimple "#pragma acc loop collapse\\(2\\) private\\(j\\) private\\(i\\)" 1
> c-c++-common/goacc/loop-private-1.c scan-tree-dump-times gimple "#pragma acc loop collapse\\(2\\) private\\(j\\) private\\(i\\)" 1
> 
> ## Differences found:Â
> # 1 differences in 11 common sum files found
> 
> 
> The error is due to mis-comparison because of reordering of private(i) private(j).
> 
> I wanted to know if the order of the private flags matter.

It doesn't matter.  (I have not reviewed the proposed changes/patches
themselves.)


GrÃÃe,
 Thomas

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K

References:
- Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: vax mzn
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Steven Bosscher
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Richard Biener
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Jonathan Wakely
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Trevor Saunders
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Richard Biener
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Prathamesh Kulkarni
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]