This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).

From: Aditya K <hiraditya at msn dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
Cc: Richard Biener <richard dot guenther at gmail dot com>, Steven Bosscher <stevenb dot gcc at gmail dot com>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
Date: Fri, 13 Mar 2015 19:32:03 +0000
Subject: RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
Authentication-results: sourceware.org; auth=none
References: <BLU179-W40C136025D7BD569ABEE24B61B0 at phx dot gbl> <CABu31nMN2KajAC4LO=RBrmxG9gHapMJmWbBC=8i_i9RyieZ5pA at mail dot gmail dot com> <CAFiYyc3uGtRxXN_bdTSHNeBTCX41JnNT3SYs2CAyYXs0_2sR5g at mail dot gmail dot com> <BLU179-W86E1C1E984B9AE31FCC5DBB6070 at phx dot gbl>,<CAH6eHdRWUfuVEac-4aZTayBCr5BmbzELNPEz62-FNpr44ihksw at mail dot gmail dot com>

You're right. I'll change this to:

/* A stable comparison functor to sort trees.  */
struct tree_compare_decl_uid {
  bool  operator ()(const tree &xa, const tree &xb) const
  {
    return DECL_UID (xa) < DECL_UID (xb);
  }
};

New patch attached.


Thanks,
-Aditya


----------------------------------------
> Date: Fri, 13 Mar 2015 19:02:11 +0000
> Subject: Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
> From: jwakely.gcc@gmail.com
> To: hiraditya@msn.com
> CC: richard.guenther@gmail.com; stevenb.gcc@gmail.com; gcc@gcc.gnu.org
>
> Are you sure your compare_variables functor is correct?
>
> Subtracting the two values seems very strange for a strict weak ordering.
>
> (Also "compare_variables" is a pretty poor name!)

Attachment: splay.patch
Description: Binary data

Follow-Ups:
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Trevor Saunders

References:
- Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: vax mzn
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Steven Bosscher
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Richard Biener
- RE: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Aditya K
- Re: Proposal for adding splay_tree_find (to find elements without updating the nodes).
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]