This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Unused components in sese.[hc]?
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Lawrence Crowl <crowl at googlers dot com>
- Cc: "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Sun, 25 Nov 2012 14:07:01 +0100
- Subject: Re: Unused components in sese.[hc]?
- References: <CAGqM8fbM5PB5Xe6Z9-VRLvyuToQTuFn21nQCS6hEijX4YL++uw@mail.gmail.com>
On Tue, Nov 20, 2012 at 2:45 AM, Lawrence Crowl <crowl@googlers.com> wrote:
> I believe the following components in sese.[hc] are completely unused.
>
> phis -- functions declared extern in sese.h but never defined
>
> extern void insert_loop_close_phis (htab_t, loop_p);
> extern void insert_guard_phis (basic_block, edge, edge, htab_t, htab_t);
>
> ivtype_map -- the hash table infrastructure is defined but never used.
>
> (In particular, the hash function and equality functions are defined
> but never used, and so no instances of the hash table can exist.)
>
> static inline ivtype_map_elt
> new_ivtype_map_elt (const char *cloog_iv, tree type)
> static void debug_ivtype_elt (ivtype_map_elt elt);
> static int debug_ivtype_map_1 (void **slot, void *s ATTRIBUTE_UNUSED);
> DEBUG_FUNCTION void debug_ivtype_map (htab_t map);
> hashval_t ivtype_map_elt_info (const void *elt);
> int eq_ivtype_map_elts (const void *e1, const void *e2);
>
> I have successfully built and tested with these components #if'd out.
> Should I remove them?
Yes, counts as obvious.
Thanks,
Richard.
> --
> Lawrence Crowl