This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: df_changeable_flags use in combine.c


On 01/05/2010 07:12 AM, Matt wrote:
Hi,

I'm fixing some compiler errors when configuring with
--enable-build-with-cxx, and ran into a curious line of code that may
indicate a bug:

static unsigned int
rest_of_handle_combine (void)
{
int rebuild_jump_labels_after_combine;

df_set_flags (DF_LR_RUN_DCE + DF_DEFER_INSN_RESCAN);
// ...
}

The DF_* values are from the df_changeable_flags enum, whose values are
typically used in logical and/or operations for masking purposes. As
such, I'm guessing the author may have meant to do:
df_set_flags (DF_LR_RUN_DCE & DF_DEFER_INSN_RESCAN);

I think you meant "|". I think "+" is same as "|" here.

And I didn't see this error when --enable-build-with-cxx for current trunk head. But I see other errors.


Jie



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]