Re: Mis-handled ColdFire submission?

[Nathan Sidwell <nathan at codesourcery dot com>]

Rask Ingemann Lambertsen wrote:

>    My only critisism is that surely, all these improvements weren't carried
> out just last week. I.e. some of them could have been submitted earlier,
> thereby making them available to users earlier as well as preventing
> duplicate work. An example is PR target/28181, which was reported half a
> year ago and at least three people worked on fixing. So once your patches
> are ready, go ahead and submit them.

We (well, Richard mainly) fixed several bugs that were also in mainline during 
the redevelopment of this coldfire port, and those did go into mainline.

In preparing the patch set for submission, Richard found and fixed several 
additional bugs and made several improvements (such as RTL thunks) -- and that 
work was done just last month.  It may be that 28181 was one that could have 
been submitted earlier, or perhaps Richard's fix relied on some piece of the 
reworking that isn't in mainline, or perhaps Richard fixed it during the merge 
(I don't recall).

The major chunk of this reworking has been blocked from going into mainline 
because GCC was in stages 2 & 3 for much of this year.  When it was in stage 1, 
we weren't in a position to add things coherently.  We've not deliberately been 
holding back on patches that could have gone in earlier.

nathan
--
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk