This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Mis-handled ColdFire submission?


I know Andrew replied privately, but I hope he doesn't mind me raising
the issue on-list.  I just wanted to guage the general feeling as to
whether I'd screwed up, and whether I should have submitted the patches
in a different way.

Richard


--- Begin Message ---
[off-list]

Posting sixty patches at once?  This isn't going to be a new trend, is
it?  Because it really sucks...

Andrew.

--- End Message ---
--- Begin Message ---
On Wed, 2007-01-10 at 18:03 +0000, Andrew Haley wrote:
> [off-list]
> 
> Posting sixty patches at once?  This isn't going to be a new trend, is
> it?  Because it really sucks...
I don't think it's that bad.  It certainly makes the review a lot 
easier.

jeff


--- End Message ---
--- Begin Message ---
Jeffrey Law writes:
 > On Wed, 2007-01-10 at 18:03 +0000, Andrew Haley wrote:
 > > [off-list]
 > > 
 > > Posting sixty patches at once?  This isn't going to be a new trend, is
 > > it?  Because it really sucks...
 > I don't think it's that bad.  It certainly makes the review a lot 
 > easier.

Mm, but it has the effect that only the first couple of patches are
lookd at by anyone other than the poster and the reviewer.  I suppose
you could argue that in the case of ColdFire that would be true
anyway.  It also discourages outsiders from contributing.

Andrew.


--- End Message ---
--- Begin Message ---
On Wed, 2007-01-10 at 18:59 +0000, Andrew Haley wrote:
> Jeffrey Law writes:
>  > On Wed, 2007-01-10 at 18:03 +0000, Andrew Haley wrote:
>  > > [off-list]
>  > > 
>  > > Posting sixty patches at once?  This isn't going to be a new trend, is
>  > > it?  Because it really sucks...
>  > I don't think it's that bad.  It certainly makes the review a lot 
>  > easier.
> 
> Mm, but it has the effect that only the first couple of patches are
> lookd at by anyone other than the poster and the reviewer.  I suppose
> you could argue that in the case of ColdFire that would be true
> anyway.  It also discourages outsiders from contributing.
There'll likely be some that I won't/can't review.  More likely than
not those will have to be ping'd if nobody notices them.

What else would you suggest?


Jeff.


--- End Message ---

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]