This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix warnings in treelang/parse.y


Rafael Ávila de Espíndola <rafael.espindola@gmail.com> writes:

| The attached patch fixes the following warnings
| 
| ../../gcc/gcc/treelang/parse.y: In function yyparse:
| ../../gcc/gcc/treelang/parse.y:532: warning: too many arguments for format
| ../../gcc/gcc/treelang/parse.y:641: warning: conversion lacks type at end of 
| format
| 
| I am not sure if this is the best fix. I could not find much documentation 
| about the syntax of the format string of "error" and "warning".

See the documentation for pp_base_format() in $GCC/gcc/pretty-print.c

| Because of 
| this, I have used similar messages present in other parts of gcc as examples.
| 
| bootstrapped and tested (make check-treelang) in i686.

The changes are basically OK.  As a bonus, you might to take the
opportunity to remove the trailing periods and decapitalize the first
words.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]