Re: Fortran left broken for a couple of days now

[Jan Hubicka <jh at suse dot cz>]

> Honza,
> 
> Your patch here: http://gcc.gnu.org/ml/gcc-patches/2005-06/msg00976.html
> has left a number of fortran test cases broken (e.g. gfortran.dg/select_2).
> 
> The problem seems to be that you used the aux field as a replacement for
> rbi->copy_number, but tree_verify_flow_info assumes aux is cleared before
> it is called (see the SWITCH_EXPR case, "gcc_assert (!label_bb->aux ....)").
> You must have seen this if you tested your patch with checking enabled, the
> patch broke fortran on all platforms.

I really apologize for that.  I must've messed up testing here
seriously.  I am pretty sure I was testing both with checking disabled
and enabled to see runtime performance and perhaps just saw the first
report from tester, but still it don't explain how I missed the
vectorizer failures (tought I am pretty sure I saw those failures
previously and my incarnation of PR22088 fix actually come from older
version of patch).  It is obviously pilot error here And I believed that
writting scripts to mostly automate testing would prevent me from such a
stupid bugs...

I think proper fix would be to simply avoid this verify_flow_info call
when the transformation is not finished yet like we do in other passes
using aux field.  I am traveling now but I will try to dig out the
backtrace today or tomorrow and fix that.

Honza
> 
> Can you please fix this? (It is also http://gcc.gnu.org/PR22100)
> 
> Gr.
> Steven
>