This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [ tree-ssa] PRE problem
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Daniel Berlin <dberlin at dberlin dot org>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Fri, 20 Feb 2004 14:56:07 -0500
- Subject: Re: [ tree-ssa] PRE problem
- Organization: Red Hat Canada
- References: <200402201947.i1KJlIpI002629@speedy.slc.redhat.com>
On Fri, 2004-02-20 at 14:47, law@redhat.com wrote:
> In message <1077304036.3169.162.camel@localhost.localdomain>, Diego Novillo wri
> tes:
> >
> >See if this (untested) patch fixes your problem. We were not calling
> >propagate_value in generate_expr_as_of_bb. This fixes PR14153, but I
> >haven't checked other places in PRE where we may be doing the same.
> I think something like this is what we need:
>
So, essentially add the may_propagate_copy to PRE? Sure.
I assume that the zillion aborts where in conjunction with your current
patch? I'm currently bootstrapping with the patch I sent earlier and
the compiler has bootstrapped and I'm well into libjava with no errors.
> I'm primarily concerned about having EREF_STMT pointing to NULL in the
> case where we could not generate the expression. I just don't know the
> code well enough to know if that might trigger undesirable effects.
>
Dunno. Dan?
> I believe we also want to make propagate_copy static and only export the more
> generic propagate_value.
>
Yup. Agreed.
Diego.