This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [COMMITTED] Fix Re: <altivec.h> not happy with 3.4 on powerpc-apple-darwin7.2.0

From: Segher Boessenkool <segher at kernel dot crashing dot org>
To: Andrew Pinski <pinskia at physics dot uc dot edu>
Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, "Timothy J. Wood" <tjw at omnigroup dot com>, gcc mailing list <gcc at gcc dot gnu dot org>
Date: Thu, 22 Jan 2004 09:49:45 +0100
Subject: Re: [PATCH] [COMMITTED] Fix Re: <altivec.h> not happy with 3.4 on powerpc-apple-darwin7.2.0
References: <F013576D-49EC-11D8-8B22-0003933F3BC2@omnigroup.com> <71F1890A-49EF-11D8-9D69-000393A6D2F2@physics.uc.edu> <E20C3A72-4C86-11D8-90BE-000A95A4DC02@kernel.crashing.org>

I never heard about extern "C++" -- what is it, where is it documented?

Wow, it turns out, I don't know C++ at all.

+}//extern "C++"
This is wrong; please use a /* */ comment (yes I use std=gnu99 for all my own code, but not everyone does) (and coding conventions require some more spaces, too ;-) )

Never mind, this was in #ifdef __cplusplus protected code, as Andrew pointed out to me privately. Which leaves only the spaces issue ;-)

Segher

References:
- <altivec.h> not happy with 3.4 on powerpc-apple-darwin7.2.0
  - From: Timothy J. Wood
- [PATCH] [COMMITTED] Fix Re: <altivec.h> not happy with 3.4 on powerpc-apple-darwin7.2.0
  - From: Andrew Pinski
- Re: [PATCH] [COMMITTED] Fix Re: <altivec.h> not happy with 3.4 on powerpc-apple-darwin7.2.0
  - From: Segher Boessenkool

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]