This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Instruction bundling on IA64 and the Intel Assembler


Richard Kenner wrote:
> 
>     Unfortunately I have no time for this.
> 

  I don't like when the sentence used without context.  I meant the
article here not the comments.  By the way when I wrote the patch, in my
opinion I wrote the comments enough to understand the code and e.g.
Richard Henderson understood the code.  It is far from the worst
example.  You can not understand the code without some work on the
code.  There should be a balance with comment size and the code. 
Sometimes a lot of comments is even worse.  I am going to write more
comments because you are asking me not because I am agree that the
comments are not enough.

> This is a perfect example of why patches should not be approved until
> they are adequately documented.  It's *very* hard (often impossible)
> to get that done later.  Indeed it's usually recommended to write the
> comments *before* the code.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]