This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] Bootstraps broken on alpha, ia64 and ppc. Branch closed.
- From: Jan Hubicka <jh at suse dot cz>
- To: Diego Novillo <dnovillo at redhat dot com>
- Cc: Jeff Law <law at redhat dot com>, Richard Henderson <rth at redhat dot com>,Andrew Macleod <amacleod at redhat dot com>, Jan Hubicka <jh at suse dot cz>,Jason Merrill <jason at redhat dot com>,Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>,Daniel Berlin <dberlin at dberlin dot org>,"gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Thu, 27 Nov 2003 09:22:17 +0100
- Subject: Re: [tree-ssa] Bootstraps broken on alpha, ia64 and ppc. Branch closed.
- References: <1069854900.5057.3.camel@frodo.toronto.redhat.com> <1069906145.6286.11.camel@frodo.toronto.redhat.com>
>
> I've reverted this patch for the time being.
>
> * Makefile.in (OBJS-common): Add tree-phinodes.o.
> (tree-phinodes.o): Add dependencies.
> * tree-phinodes.c: New file.
> * tree-dfa.c (create_phi_node): Moved to tree-phinodes.o.
> (add_phi_arg, remove_phi_arg, remove_phi_arg_num): Similarly.
> (remove_phi_node, remove_all_phi_nodes_for): Similarly.
> * tree-ssa.c (init_tree_ssa): Initialize PHI node management.
> (delete_tree_ssa): Finalize PHI node management.
> * tree.c (dump_tree_statistics): Dump PHI node stats.
> (make_phi_node, resize_phi_node): Moved to tree-phinodes.o.
> * tree.h (init_phinodes): Prototype.
> (fini_phinodes, release_phi_node): Likewise.
> (phinodes_print_statistics): Likewise.
>
> Jeff, another data point that may help. I got it to fail on x86
> bootstrapping with gc,gcac. It failed while building libgcc/_gcov.o
> with the stage1 compiler, so it shouldn't take long to get to the
> failure point:
>
> /home/cygnus/dnovillo/tree-ssa-00/src/gcc/libgcov.c: In function `gcov_exit':
> /home/cygnus/dnovillo/tree-ssa-00/src/gcc/libgcov.c:424: internal compiler error: in ggc_set_mark, at ggc-page.c:1228
Interesting.
Itried precisely this and it did passed for me. Anyway I wanted to ask
how much work it would be to get GGC working during SSA compilation, so
ssa-pre don't need those pushcontext/popcontext hacks. I did play with
this and one obvious problem is that PHI nodes are referenced from
non-GCed basic blocks only. I will work around this by adding separate
linked list of referenced PHIs. Any idea whether there are other
fundamental problems?
Honza
>
> Reverting the patch allowed me to get past that failure as well. I
> think I'm going to get a new tester to do gc,gcac builds since we're
> going to be doing quite a bit of memory twiddling work in the next
> little while.
>
> I've committed the patch reversal, so the branch is open again.
>
>
> Thanks. Diego.
>