This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gcc/gcc ChangeLog doc/invoke.texi


> > Oops, thanks!  Time to go sleep today.
> 
> Not yet :-)
> 
> 	* cgraphunit.c (cgraph_expand_function): Use
> 	cgraph_possibly_inlined_p.
> 
> introduced a regression on x86:
> 
> FAIL: gcc.c-torture/execute/bcp-1.c execution,  -O1 
> 
> because
> 
> inline int bad3(int x) { return __builtin_constant_p(x); }
> 
> int main()
> {
>   if (! bad3(1))
>    abort();
> 
>   exit(0);
> }
> 
> is not inlined at -O1 anymore.
Uh.  This is latent bug in dwarf2out I copied into
flag_really_no_inline.
Fixed by attached patch I am testing right now.

2003-11-10  Jan Hubicka  <jh@suse.cz>
	* cgraph.c (cgraph_function_possibly_inlined_p): Test flag_really_no_inline.
Index: cgraph.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/cgraph.c,v
retrieving revision 1.34
diff -c -3 -p -r1.34 cgraph.c
*** cgraph.c	22 Oct 2003 19:18:03 -0000	1.34
--- cgraph.c	10 Nov 2003 19:10:44 -0000
*************** bool
*** 536,542 ****
  cgraph_function_possibly_inlined_p (tree decl)
  {
    if (!cgraph_global_info_ready)
!     return (DECL_INLINE (decl) && !flag_no_inline);
    return cgraph_node (decl)->global.inlined;
  }
  
--- 536,542 ----
  cgraph_function_possibly_inlined_p (tree decl)
  {
    if (!cgraph_global_info_ready)
!     return (DECL_INLINE (decl) && !flag_really_no_inline);
    return cgraph_node (decl)->global.inlined;
  }
  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]