This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Update on bugzilla stuff


On Tue, 1 Jan 2002, Jakub Jelinek wrote:

> On Tue, Jan 01, 2002 at 05:37:26PM -0500, Daniel Berlin wrote:
> > This is hard to fix, because it would mean special casing lynx.
> > This is because it's a lynx problem, other text mode browsers like 
> > links/w3m lay it out fine.
> > I'm a text browser person too, and i stopped using lynx about a year ago.
> 
> Unfortunately links cookies support is horrible and bugzilla relies on it.
> Beeing a text console person too, I'm currently stuck with links for almost
> all browsing but bugzilla and lynx for bugzilla.

Actually, the links cookie support is just buggy for the most part.
It's fairly easy to fix, the bug is stupid.
It exists in both links and elinks.
In cookies.c, at line 81 (second line of real code in set_cookies), it 
returns 0 if the cookie name or value contains whitespace in it.

Bugzilla cookies do, because the login name is never trimmed of 
trailing blanks.

So, just change the line from
for (p = str; *p != ';' && *p; *p++) if (WHITECHAR((*p)) return 0;
to
for (p = str; *p != ';' && *p; *p++);
if (!*p)
	return 0;


And bugzilla cookies should work fine.
At least, it now knows i'm logged in.

> 
> 	Jakub
> 



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]