This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Patch commit requirements
- To: gcc at gcc dot gnu dot org
- Subject: Patch commit requirements
- From: Geoff Keating <geoffk at geoffk dot org>
- Date: Wed, 20 Jun 2001 13:42:55 -0700
- CC: jh at suse dot cz, amylaar at redhat dot com, law at cygnus dot com
- Reply-to: Geoff Keating <geoffk at redhat dot com>
This is a reminder that generally, before checking in a change, you
should do all the following:
- Ensure that the tree still bootstraps and all languages test OK.
- When you post your change (the exact change you plan to commit) to
gcc-patches, indicate what platform you have used for testing.
These rules apply to every commit you make, no matter how it got
approved.
The second requirement is almost as important as the first. Suppose
you commit a patch that happens to break the build on some platform.
Without knowing what platform you tested it on, the only assumption
that can be made is that the patch never worked, that you never
tested it, and that the patch is completely broken.
I'm considering simply reverting such patches in the future, as soon
as I get the report of the build failure. Does anyone think this
unreasonable?
--
- Geoffrey Keating <geoffk@geoffk.org>