Re: [PATCH] arm: Generate correct const_ints (PR86640)

[Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>]

Hi Segher,

On 30/07/18 14:14, Segher Boessenkool wrote:
> In arm_block_set_aligned_vect 8-bit constants are generated as zero-
> extended const_ints, not sign-extended as required.  Fix that.
>
> Tamar tested the patch (see PR); no problems were found.  Is this okay
> for trunk?

The patch is okay but please add the testcase from the PR to gcc.dg/
or somewhere else generic (it's not arm-specific).
Thanks Tamar for testing.

Kyrill

> Segher
>
>
> 2018-07-30  Segher Boessenkool <segher@kernel.crashing.org>
>
>         PR target/86640
>         * config/arm/arm.c (arm_block_set_aligned_vect): Use gen_int_mode
>         instead of GEN_INT.
>
> ---
>  gcc/config/arm/arm.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> index cf12ace..f5eece4 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -30046,7 +30046,6 @@ arm_block_set_aligned_vect (rtx dstbase,
>    rtx dst, addr, mem;
>    rtx val_vec, reg;
>    machine_mode mode;
> -  unsigned HOST_WIDE_INT v = value;
>    unsigned int offset = 0;
>
>    gcc_assert ((align & 0x3) == 0);
> @@ -30065,10 +30064,8 @@ arm_block_set_aligned_vect (rtx dstbase,
>
>    dst = copy_addr_to_reg (XEXP (dstbase, 0));
>
> -  v = sext_hwi (v, BITS_PER_WORD);
> -
>    reg = gen_reg_rtx (mode);
> -  val_vec = gen_const_vec_duplicate (mode, GEN_INT (v));
> +  val_vec = gen_const_vec_duplicate (mode, gen_int_mode (value, QImode));
>    /* Emit instruction loading the constant value.  */
>    emit_move_insn (reg, val_vec);
>
> --
> 1.8.3.1