This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Kugan Vivekanandarajah <kugan dot vivekanandarajah at linaro dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 6 Jul 2018 12:17:15 +0200
- Subject: Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p
- References: <CAELXzTN9VCY=zsT7t5aex6GNEgXyG9TpGOPbNDgU4+pO5S6ZMA@mail.gmail.com> <CAFiYyc3M3RpFWLw2GgwzWvz4=pF910jwUt+5JhkZgkqTYAiRKQ@mail.gmail.com> <CAELXzTOzMtmoAFEWTgHFZEep3J8xOApT+9Bq+eas3YoubZpH1g@mail.gmail.com> <CAFiYyc1zP03q+FZS15wd9hT4PKLuZWU1fPwMYjogzTxVj7VaTQ@mail.gmail.com> <CAELXzTOjHDomGp9+2uuKOP5EbQYmtijqf5j9ROcR1Wzif7q3cA@mail.gmail.com> <CAFiYyc0ATyF-FepYEwrEMN+uDWZeFp=3U93AU+--znDfMGPnBg@mail.gmail.com> <CAFiYyc3rBbassyVzJPL+QZHcMuv3u8ATZkvwRxVUQsDrLgb6og@mail.gmail.com> <CAELXzTO3WjxmWBtspDxu=EmFt__kN3pbpmc9fFecj1q3ZBKeTA@mail.gmail.com>
On Fri, Jul 6, 2018 at 11:45 AM Kugan Vivekanandarajah
<kugan.vivekanandarajah@linaro.org> wrote:
>
> Hi Richard,
>
> > It was rewrite_to_non_trapping_overflow available in tree.h. Thus
> > final value replacement
> > could use that before gimplifying instead of using rewrite_to_defined_overflow
> Thanks.
>
> Is the attached patch OK? I am testing this on x86_64-linux-gnu and if
> there is no new regressions.
Please clean up the control flow to
if (...)
def = rewrite_to_non_trapping_overflow (def);
def = force_gimple_operand_gsi (&gsi, def, false, NULL_TREE,
true, GSI_SAME_STMT);
OK with that change.
Richard.
> Thanks,
> Kugan
>
> gcc/ChangeLog:
>
> 2018-07-06 Kugan Vivekanandarajah <kuganv@linaro.org>
>
> * tree-scalar-evolution.c (final_value_replacement_loop): Use
> rewrite_to_non_trapping_overflow instead of rewrite_to_defined_overflow.