This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Improve specs processing to allow %* in function arguments
- From: Jeff Law <law at redhat dot com>
- To: Olivier Hainque <hainque at adacore dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 5 Jul 2018 14:35:53 -0600
- Subject: Re: [patch] Improve specs processing to allow %* in function arguments
- References: <A28858FF-9F09-4AF1-BCDD-C743C18742FD@adacore.com>
On 06/05/2018 08:13 AM, Olivier Hainque wrote:
> Hello,
>
> The attached patch is a proposal to improve specs processing
> so %* works in spec function arguments (it doesn't as of today).
>
> The immediate motivation is to allow a cleaner implementation of
> the -mmacosx-version-min support on darwin. I'll send a followup
> patch for that if the preliminary improvement suggested here gets
> approved. It seems generally useful in any case.
>
> The idea is to propagate the matched pattern down into the spec
> processing chain when we have it, in particular from do_spec_1 to
> handle_spec_function, to eval_spec_function, to do_spec_2 and
> then do_spec_1 for the arguments.
>
> Testing-wise, we have this running nightly on all our targets,
> currently based on gcc-7. We are using the facility on darwin in
> particular, with the reworked support for -mmacosx-version-min
> combined with local changes to support -mios-version-min as well.
>
> Bootstrapped and regression tested with mainline on x86_64-linux.
>
> Ok to commit ?
>
> Thanks a lot in advance!
>
> With Kind Regards,
>
> Olivier
>
> 2018-06-05 Olivier Hainque <hainque@adacore.com>
>
> * gcc.c (handle_spec_function): Accept a soft_matched_part
> argument, as do_spec_1. Pass it down to ...
> (eval_spec_function): Accept a soft_matched_part argument,
> and pass it down to ...
> (do_spec_2): Accept a soft_matched_part argument, and pass
> it down to do_spec_1.
> (do_spec_1): Pass soft_matched_part to handle_spec_function.
> (handle_braces): Update call to handle_spec_function.
> (driver::set_up_specs): Update calls to do_spec_2.
> (compare_debug_dump_opt_spec_function): Likewise.
> (compare_debug_self_opt_spec_function): Likewise.
OK.
jeff