This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Make groups more generic (PR gcov-profile/84548).

From: Martin Liška <mliska at suse dot cz>
To: Nathan Sidwell <nathan at acm dot org>, gcc-patches at gcc dot gnu dot org
Date: Tue, 27 Feb 2018 15:11:14 +0100
Subject: Re: [PATCH] Make groups more generic (PR gcov-profile/84548).
Authentication-results: sourceware.org; auth=none
References: <62ab3cdf-6093-fbde-4e9d-90a092e2e4b1@suse.cz> <babbc671-0069-dc8d-a27a-4c5ce7162e16@acm.org>

On 02/27/2018 02:01 PM, Nathan Sidwell wrote:
> On 02/27/2018 07:45 AM, Martin Liška wrote:
>> Hi.
>>
>> Considering following C++ code snippet:
> 
>> gcc/ChangeLog:
>>
>> 2018-02-26  Martin Liska  <mliska@suse.cz>
>>
>>     PR gcov-profile/84548
>>     * gcov.c (process_file): Allow partial overlap and consider it
>>     also as group functions.
>>     (output_lines): Properly calculate range of lines for a group.
> 
> Ok, but fix comment:
> 
> +          /* It's possible to have function that partially overlap,
> pluralize 'function'
> +         thus take the maximum end_line of got functions.  */
> 'got functions'?
> 

Thanks.

Fixed that and installed as r258033.

Martin

References:
- [PATCH] Make groups more generic (PR gcov-profile/84548).
  - From: Martin Liška
- Re: [PATCH] Make groups more generic (PR gcov-profile/84548).
  - From: Nathan Sidwell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]