This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFC (DECL_CONSTRUCTOR_P): C++ PATCH for c++/83911, ICE with multiversioned constructor

From: Nathan Sidwell <nathan at acm dot org>
To: Jason Merrill <jason at redhat dot com>
Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>
Date: Fri, 16 Feb 2018 18:41:49 -0500
Subject: Re: RFC (DECL_CONSTRUCTOR_P): C++ PATCH for c++/83911, ICE with multiversioned constructor
Authentication-results: sourceware.org; auth=none
References: <CADzB+2mscyD4RO7jz-JVxWZ0hvqy6RdMmG2E3XQgPUy9-5y9ng@mail.gmail.com>

On 02/16/2018 05:48 PM, Jason Merrill wrote:

We hit the bug in this testcase because build_over_call replaces the
constructor with a dispatcher function, and then build_aggr_init_expr
doesn't recognize it as a constructor.

Messing with the DECL_NAME of the dispatcher seems messy, but copying
the DECL_CXX_CONSTRUCTOR_P flag is easy.  So we can change the test in
build_aggr_init_expr, or change the definition of DECL_CONSTRUCTOR_P.
I lean toward the latter as more uniform, but not strongly.  Do you
have an opinion?

Using the ctor name for the dispatcher doesn't seem wonky to me -- it is afterall a constructor. But then I've not looked at the code. Might be bored inairports tomorrow ... If I fail to respond, go with your approach.


nathan

--
Nathan Sidwell

References:
- RFC (DECL_CONSTRUCTOR_P): C++ PATCH for c++/83911, ICE with multiversioned constructor
  - From: Jason Merrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]