This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 9 Feb 2018 15:21:16 -0800
- Subject: Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qj7h9WFAvMs5o1CnUbBEkM1pmUQtNPOLXUhD+YREdRe+w@mail.gmail.com>
- Reply-to: sgk at troutmask dot apl dot washington dot edu
On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote:
>
> the attached patch fixes some checking code for PASS arguments in
> procedure-pointer components, which does not properly account for the
> fact that the PASS argument needs to be polymorphic.
>
> [The reason for this issue is probably that PPCs were mostly
> implemented before polymorphism was available. The corresponding
> pass-arg checks for TBPs are ok.]
>
> The patch also fixes an invalid test case (which was detected thanks
> to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for
> trunk?
Janus,
The patch looks ok to me. Trunk is in regression and doc
fixes only mode, so you'll probably need to ping Jakub or
Richard (ie., release engineer) for an ok.
PS: Welcome back! We can definitely use your talent.
--
Steve