This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions
- From: Tom de Vries <Tom_deVries at mentor dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Alexander Monakov <amonakov at ispras dot ru>, Thomas Schwinge <thomas at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 6 Feb 2018 12:46:45 +0100
- Subject: Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions
- Authentication-results: sourceware.org; auth=none
- References: <7bfb59de-a141-46b4-0c6d-91ecd5b2a766@codesourcery.com> <ddc64317-55c0-e51f-4164-5ced5e72d7bc@codesourcery.com>
On 12/21/2017 10:46 PM, Cesar Philippidis wrote:
I've committed this patch to openacc-gcc-7-branch.
diff --git a/gcc/omp-expand.c b/gcc/omp-expand.c
index bf1f127d8d6..f674c74ec82 100644
--- a/gcc/omp-expand.c
+++ b/gcc/omp-expand.c
offloaded = is_gimple_omp_offloaded (entry_stmt);
switch (gimple_omp_target_kind (entry_stmt))
{
+ case GF_OMP_TARGET_KIND_OACC_PARALLEL:
+ oacc_parallel = true;
case GF_OMP_TARGET_KIND_REGION:
case GF_OMP_TARGET_KIND_UPDATE:
case GF_OMP_TARGET_KIND_ENTER_DATA:
case GF_OMP_TARGET_KIND_EXIT_DATA:
- case GF_OMP_TARGET_KIND_OACC_PARALLEL:
case GF_OMP_TARGET_KIND_OACC_KERNELS:
case GF_OMP_TARGET_KIND_OACC_UPDATE:
case GF_OMP_TARGET_KIND_OACC_ENTER_EXIT_DATA:
This broke openacc-gcc-7-branch bootstrap:
...
gcc/omp-expand.c: In function 'void expand_omp_target(omp_region*)':
gcc/omp-expand.c:7110:21: error: this statement may fall through
[-Werror=implicit-fallthrough=]
oacc_parallel = true;
~~~~~~~~~~~~~~^~~~~~
gcc/omp-expand.c:7111:5: note: here
case GF_OMP_TARGET_KIND_REGION:
^~~~
...
Thanks,
- Tom