This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] fix-ups for vec-cmpne-long.c runtime tests
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Will Schmidt <will_schmidt at vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, David Edelsohn <dje dot gcc at gmail dot com>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Fri, 2 Feb 2018 09:18:39 -0600
- Subject: Re: [PATCH, rs6000] fix-ups for vec-cmpne-long.c runtime tests
- Authentication-results: sourceware.org; auth=none
- References: <1517428237.11602.249.camel@brimstone.rchland.ibm.com>
Hi!
On Wed, Jan 31, 2018 at 01:50:37PM -0600, Will Schmidt wrote:
> The vec-cmpne-long.c tests targets -mcpu=power8, but always dg-do-run, even
> on P7 (or earlier) systems. Add a dg-do run requirement for p8vector_hw to
> prevent illegal instruction errors.
> (noticed during review of test results from a P7).
>
> Sniff tests look good.
>
> OK for trunk?
Yes please, thanks! Some trivialities:
> -/* { dg-do run { target { powerpc64*-*-* } } } */
> +/* { dg-do run { target { powerpc64*-*-* && { p8vector_hw } } } } */
Should this be powerpc*-*-* instead? Which is already implied of course,
this is on gcc.target/powerpc. And you don't need braces around
p8vector_hw if you put it first.
Segher