This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch][Aarch64] Fix multi-arch support in ILP32 mode
- From: Matthias Klose <doko at ubuntu dot com>
- To: sellcey at cavium dot com, James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, nd at arm dot com, wookey at arm dot com
- Date: Thu, 21 Dec 2017 23:54:42 +0100
- Subject: Re: [Patch][Aarch64] Fix multi-arch support in ILP32 mode
- Authentication-results: sourceware.org; auth=none
- References: <1513882582.5026.74.camel@cavium.com> <20171221205511.GA38061@arm.com> <1513893541.5026.75.camel@cavium.com>
On 21.12.2017 22:59, Steve Ellcey wrote:
> On Thu, 2017-12-21 at 20:55 +0000, James Greenhalgh wrote:
>> On Thu, Dec 21, 2017 at 06:56:22PM +0000, Steve Ellcey wrote:
>>>
>>> This one line patch for multi-arch support on Aarch64 and ILP32 was
>>> submitted over a year ago and pinged a number of time since then,
>>> since no one has objected and since it is only one line I am going
>>> to check it in as an obvious fix.
>> I think this is not obvious, and worse incorrect. I contacted Andrew
>> off-list back in September to ask about this patch, the problem is
>> the
>> triplet used here:
>>
>>>
>>> -MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32
>>> +MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32$(call
>>> if_multiarch,:aarch64$(AARCH_BE)_ilp32-linux-gnu)
>> As far as I understand it from Linaro connect and conversations with
>> Debian/Ubuntu port maintainers, the correct triplet should be:
>>
>> aarch64-none-linux-gnu_ilp32
>>
>> If you're revisiting this patch, it is OK to go in, but please use the
>> agreed triplet.
well, it's called triplet, not quadruplet. No other multiarch tuple contains an
explicit vendor field. Do you really want to use that?
>> Thanks,
>> James
>
> OK, I fixed the triplet and checked it in.
hmm ...
Matthias