This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch][Aarch64] Fix multi-arch support in ILP32 mode


On Thu, 2017-12-21 at 20:55 +0000, James Greenhalgh wrote:
> On Thu, Dec 21, 2017 at 06:56:22PM +0000, Steve Ellcey wrote:
> > 
> > This one line patch for multi-arch support on Aarch64 and ILP32 was
> > submitted over a year ago and pinged a number of time since then,
> > since no one has objected and since it is only one line I am going
> > to check it in as an obvious fix.
> I think this is not obvious, and worse incorrect. I contacted Andrew
> off-list back in September to ask about this patch, the problem is
> the
> triplet used here:
> 
> > 
> > -MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32
> > +MULTILIB_OSDIRNAMES += mabi.ilp32=../libilp32$(call
> > if_multiarch,:aarch64$(AARCH_BE)_ilp32-linux-gnu)
> As far as I understand it from Linaro connect and conversations with
> Debian/Ubuntu port maintainers, the correct triplet should be:
> 
>   aarch64-none-linux-gnu_ilp32
> 
> If you're revisiting this patch, it is OK to go in, but please use the
> agreed triplet.
> 
> Thanks,
> James

OK, I fixed the triplet and checked it in.

Steve Ellcey


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]