This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>
- Cc: Alexander Monakov <amonakov at ispras dot ru>, Thomas Schwinge <thomas at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 21 Dec 2017 22:52:21 +0100
- Subject: Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions
- Authentication-results: sourceware.org; auth=none
- References: <7bfb59de-a141-46b4-0c6d-91ecd5b2a766@codesourcery.com> <ddc64317-55c0-e51f-4164-5ced5e72d7bc@codesourcery.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Dec 21, 2017 at 01:46:56PM -0800, Cesar Philippidis wrote:
> After thinking about this some more, I decided that it would be better
> expand the offloaded function arguments into individual parameters
> during omp lowering, rather than writing a separate pass later on. I
> don't see too many disadvantages of using libffi after a pthread is
> spawned by the host. If anything, the pthread's use of libffi is
> equivalent of preforming SRA by the accelerator anyway.
I'll have a look at your previous patch, just want to say that using libffi
for this or changing anything for non-nvptx targets seems to be very bad
idea to me.
Jakub