This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Follow-on fix for PR target/80210: ICE in extract_insn
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Peter Bergner <bergner at vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Date: Mon, 2 Oct 2017 12:10:50 -0500
- Subject: Re: [PATCH, rs6000] Follow-on fix for PR target/80210: ICE in extract_insn
- Authentication-results: sourceware.org; auth=none
- References: <ecbe6ac7-af09-4cb0-fdb5-ccbd69239b01@vnet.ibm.com> <20170929223120.GT8421@gate.crashing.org> <dd9786b5-c94b-cf66-2d7f-c0c9a16d9919@vnet.ibm.com>
On Mon, Oct 02, 2017 at 12:00:55PM -0500, Peter Bergner wrote:
> On 9/29/17 5:31 PM, Segher Boessenkool wrote:
> >> + /* PowerPC 64-bit LE requires at least ISA 2.07. */
> >> + const char *default_cpu = ((!TARGET_POWERPC64)
> >> + ? "powerpc"
> >> + : ((BYTES_BIG_ENDIAN)
> >> + ? "powerpc64"
> >> + : "powerpc64le"));
> >
> > Please remove the parens around !TARGET_POWERPC64 and BYTES_BIG_ENDIAN
> > while you're at it (one of the copies you removed had that already :-) )
>
> Done.
>
>
> > Looks great to me, please commit. But hold off until Monday please, it
> > will interfere with testing otherwise.
>
> Ok, committed now (Monday). I'd also like to back port this to the
> GCC 7 and 6 release branches, where the earlier fix was also back
> ported to. Ok there after a week or so of burn in on trunk?
Certainly. Thanks!
Segher