This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class
- From: Jason Merrill <jason at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, Markus Trippelsdorf <markus at trippelsdorf dot de>
- Date: Tue, 26 Jan 2016 14:27:40 -0500
- Subject: Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOo9pcJ_75FmUSs62PBf-neM=+-ftqOD=ffpOm7p6Grx7Q at mail dot gmail dot com> <CAFiYyc2Qx3DfTraZjUCR0Ha17++SNU-4d5SjGMSWn1hZWKK4uA at mail dot gmail dot com> <CAMe9rOrMC4XjhFW-a1TdGD2SJo7=yhtGX8r=KxLEyit1WLwpog at mail dot gmail dot com> <20151209213118 dot GC317 at x4> <CAFiYyc2jYtFdiLRdviOX3M-_BV=h_SnyTMm01jKA4ZAVnbaa6w at mail dot gmail dot com> <CAMe9rOrogonLyyMwY8BGs-ue52kO8jKiOH9q1KHxWiicWCFHkA at mail dot gmail dot com> <566C346B dot 8030601 at redhat dot com> <20151212152731 dot GB18720 at tucnak dot redhat dot com> <alpine dot DEB dot 2 dot 20 dot 1512121920570 dot 9203 at laptop-mg dot saclay dot inria dot fr> <566F23AE dot 6070604 at redhat dot com> <CAMe9rOoodvn=C0NcpHiFb3nVLr2j9vXBibpSpAcE7wKcxSt3jQ at mail dot gmail dot com> <566F2A0B dot 4010102 at redhat dot com> <CAMe9rOpRKYX5csM9PNhO6msWPMe-FAcCcixzEHiGp=WiAN567A at mail dot gmail dot com>
On 12/14/2015 05:08 PM, H.J. Lu wrote:
+ if (abi_version_at_least (10))
+ TYPE_EMPTY_RECORD (t) = is_really_empty_class (t);
This should use is_empty_class or CLASSTYPE_EMPTY_P. We don't want to
change how classes with just a vptr are passed.
Otherwise, it looks OK to me.
Jason