Re: Commit: Try harder to run ARM neon testcases

[Christian Bruel <christian dot bruel at st dot com>]

On 01/14/2016 01:37 PM, Nick Clifton wrote:
> Hi Guys
>
>    Whilst checking PR 69194 I noticed that the new testcase
>    (gcc.target/arm/pr69194.c) was not being run with a Linux hosted
>    toolchain configured as --target=arm-eabi.  Investigating further I
>    found that the check_effective_target_arm_neon_ok_nocache proc in
>    target_supports.exp was returning false because the default ARM
>    architecture was v4 not v7.
>
>    So I am applying the patch below which adds a command line option
>    sequence involving -march=armv7-a to the list of combinations to try
>    in check_effective_target_arm_neon_ok_nocache.  Whilst checking this
>    part of the patch I found several ARM tests that check for arm_neon_ok
>    but then do not use the option sequence discovered, so I have updated
>    those as well.

good step. indeed it looks like that many tests are sometimes 
conservatively unsupported

>    The result - the number of unsupported tests drops by 48 and the
>    number of passes increases by 115 for each ARM multilib tested.  Plus
>    there are no regressions or new, unexpected failures.
>
> Cheers
>    Nick
>
> gcc/testsuite/ChangeLog
> 2016-01-14  Nick Clifton  <nickc@redhat.com>
>
> 	* lib/target-supports.exp
> 	(check_effective_target_arm_neon_ok_nocache): Add an option
> 	sequence that includes setting the ARM architecture to ARMv7-A.
> 	* gcc.target/arm/attr-neon.c: Use dg-add-options to add the
> 	command line options necessary to enable Neon support.

is this last one needed ? the __attribute__ ((target("fpu=neon"))) is 
here to test without -mfpu=neon. So we are losing something here.

thanks


> 	* gcc.target/arm/neon-vlshr-imm-1.c: Likewise.
> 	* gcc.target/arm/neon-vshl-imm-1.c: Likewise.
> 	* gcc.target/arm/neon-vshr-imm-1.c: Likewise.
> 	* gcc.target/arm/pr69180.c: Likewise.