Re: [PATCH 2/4][AArch64] Add support for FCCMP

[Evandro Menezes <e dot menezes at samsung dot com>]

On 11/13/2015 11:36 AM, Wilco Dijkstra wrote:
> > Evandro Menezes wrote:
> > Hi, Wilco.
> >
> > It looks good to me, but FCMP is quite different from FCCMP on Exynos M1,
> > so it'd be helpful to have distinct types for them. Say, "fcmp{s,d}"
> > and "fccmp{s,d}".  Would it be acceptable to add this with this patch or later?
> It would be easy to add fccmps/d as new attributes, I prefer to do that as a separate
> patch. Are there any other attributes that you think are missing besides the ones I know
> about (extr, 64-bit mul/mla, mulh, bfi)?
>
> Also would we need a new entry in the cost tables?
Hi, Wilco.

I don't think that additional entries in the cost tables are needed.

However, I'm afraid that, other than the ones above, no, or perhaps a 
handful of, additional attributes will be needed.  The reason is that, 
so far, I have found few attributes that would make a noticeable 
difference.  As more performance analysis, a never ending task, is done, 
I expect some important attributes to pop, but I cannot anticipate them 
conclusively right now.

Thank you,

--
Evandro Menezes