This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c
- From: Martin LiÅka <mliska at suse dot cz>
- To: gcc-patches at gcc dot gnu dot org
- Date: Fri, 13 Nov 2015 17:58:37 +0100
- Subject: Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c
- Authentication-results: sourceware.org; auth=none
- References: <564081EF dot 7030003 at suse dot cz> <5645DCB1 dot 6070309 at suse dot cz> <564610B4 dot 9080708 at redhat dot com>
On 11/13/2015 05:32 PM, Jeff Law wrote:
> On 11/13/2015 05:50 AM, Martin Liška wrote:
>> Hello.
>>
>> Patch survives regbootstrap on x86_64-linux-gnu.
>> Ready for trunk?
>>
>> Thanks,
>> Martin
>>
>>
>> 0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch
>>
>>
>> From 54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001
>> From: marxin<mliska@suse.cz>
>> Date: Fri, 13 Nov 2015 12:23:22 +0100
>> Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c
>>
>> gcc/ChangeLog:
>>
>> 2015-11-13 Martin Liska<mliska@suse.cz>
>>
>> * tree-ssa-uninit.c (convert_control_dep_chain_into_preds):
>> Fix GNU coding style.
>> (find_def_preds): Use auto_vec.
>> (destroy_predicate_vecs): Change signature of the function.
>> (prune_uninit_phi_opnds_in_unrealizable_paths): Use the
>> new signature.
>> (simplify_preds_4): Use destroy_predicate_vecs instread of
>> just releasing preds vector.
>> (normalize_preds): Likewise.
>> (is_use_properly_guarded): Use new signature of
>> destroy_predicate_vecs.
>> (find_uninit_use): Likewise.
> OK.
>
> FWIW, there's all kinds of spaces vs tabs issues in this file. I'm curious why you chose to fix convert_control_dep_chain_into_preds, but didn't change any others.
Hi Jeff.
Thanks for confirmation, you are right, it's full of coding style issues. I can change these if it would be desired?
Thanks,
Martin
>
> Jeff