This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make disabled-optimization warning more informative; increase default max-gcse-memory


On 11/12/2015 10:08 AM, Bradley Lucier wrote:
On 11/12/2015 11:57 AM, Bernd Schmidt wrote:
The expanded warning allowed me to see how much memory really was needed
to apply gcse to some of my routines, and 128MB fixes my problem.  The
limit has been 50MB for over 10 years, I think we can up it a bit now.
  {
+  unsigned int memory_request = n_basic_blocks_for_fn (cfun)
+    * SBITMAP_SET_SIZE (max_reg_num ())
+    * sizeof (SBITMAP_ELT_TYPE);
+

Formatting (wrap in parens to get it indented).

Fixed.


Otherwise ok.

Thanks.

Here's the reformatted patch (but without retesting).

I don't have check-in privileges.

Brad

     * gcc/cprop.c (is_too_expensive): Remove.
     (gcse.h): Include.
     (one_cprop_pass): Call gcse_or_cprop_is_too_expensive, not
     is_too_expensive.
     * gcc/gcse.h (gcse_or_cprop_is_too_expensive): Declare.
     * gcc/gcse.c (is_too_expensive): Rename to ...
     (gcse_or_cprop_is_too_expensive): ... this.
     Expand warning to add required size of max-gcse-memory.
     (one_pre_gcse_pass): Use it.
     (one_code_hoisting_pass): Use it.
     * gcc/params.def (max-gcse-memory): Increase from 50MB to 128MB.
Committed on your behalf.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]