This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD
- From: Thomas Quinot <quinot at adacore dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>, Arnaud Charlet <charlet at adacore dot com>
- Cc: John Marino <gnugcc at marino dot st>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 3 Jun 2015 11:39:24 +0200
- Subject: Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD
- Authentication-results: sourceware.org; auth=none
* Eric Botcazou, 2015-06-03 :
> > Note 2) I removed reference to FreeBSD 6 and earlier. These platforms
> > have been EOL for years (FreeBSD 8 is EOL in 4 weeks)
> >
> > Note 3) FreeBSD should have switched to use errno years ago, this patch
> > does that now.
> >
> > Note 4) For all BSD except DragonFly (which doesn't support i386
> > anymore), the GCC_UNWINDER is specified for i386 platforms. It wasn't
> > specified before.
> >
> > Note 5) All the ce/cxa/cxg tests that failed on i386-FreeBSD are related
> > to the 53-bit float mantissa issue on FreeBSD. This is resolved by my
> > GNAT-AUX repository changes so the tests pass without compromising other
> > compilers, but those patches are out of scope of this set.
>
> I'm not a specialist of FreeBSD so Thomas is Cced. The original message is:
> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg02830.html
Patch looks good to me. The story with floats is that on FreeBSD, the
i386 FPU is set to 53-bit floats, but the GNAT runtime library always
issues a "finit" instruction to reset it to full precision, so we need
to reset TARGET_96_ROUND_53_LONG_DOUBLE to 0.
* Arnaud Charlet, 2015-06-03 :
> > In all likelihood, I would be the first to discover the breakage and
> > also the most likely to submit the patch. This covers all three targets
> > (both FreeBSD and the one DragonFly).
>
> OK, as long as this happens and the files do not bitrot, that's fine with me.
> What I want to avoid is a one time submit and no follow ups afterwards, and
> files which no longer work after some time, with nobody bothering fixing
> them.
John has been actively maintaining these changes for the past few years,
so I'm confident these files won't bitrot.
--
Thomas Quinot, Ph.D. ** quinot@adacore.com ** Senior Software Engineer
AdaCore -- Paris, France -- New York, USA