Re: [PATCH][ARM/AArch64 Testsuite] Cleanup advsimd-intrinsics.exp, removing unnecessary loop

[Christophe Lyon <christophe dot lyon at linaro dot org>]

On 28 May 2015 at 18:45, Alan Lawrence <alan.lawrence@arm.com> wrote:
> I've tested this on aarch64, aarch64_be, and arm, and in all cases, the same
> tests are executed (whether running the whole advsimd-intrinsics.exp, or
> manually specifying a single file). AFAICT the loop, explicit
> runtest_file_p, and gcc_set_parallelization_enable, all stem from a point
> where we were calling c-torture-execute instead of or as well as
> gcc-dg-runtest. Now we have only the latter, it is quite capable of looping
> through tests itself (and correctly parallelizing them).
>
> Ok for trunk?

This looks OK, but why can't you also drop the other torture-related
lines as you did in your previous patch?
I mean:
load_lib c-torture.exp
load_lib torture-options.exp
etc...

Christophe.

>
> Cheers, Alan
>
>
> diff --git
> a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrins
> index 583832a..19a982d 100644
> ---
> a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
> +++
> b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/advsimd-intrinsics.exp
> @@ -55,20 +55,8 @@ set-torture-options $C_TORTURE_OPTIONS {{}}
> $LTO_TORTURE_OPTI
>  set additional_flags [add_options_for_arm_neon ""]
>
>  # Main loop.
> -foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c]] {
> -    # If we're only testing specific files and this isn't one of them, skip
> it.
> -    if ![runtest_file_p $runtests $src] then {
> -       continue
> -    }
> -
> -    # runtest_file_p is already run above, and the code below can run
> -    # runtest_file_p again, make sure everything for this test is
> -    # performed if the above runtest_file_p decided this runtest
> -    # instance should execute the test
> -    gcc_parallel_test_enable 0
> -    gcc-dg-runtest $src "" $additional_flags
> -    gcc_parallel_test_enable 1
> -}
> +gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/*.c]] \
> +              "" ${additional_flags}
>
>  # All done.
>  set dg-do-what-default ${save-dg-do-what-default}
>