Re: [Patch, fortran, pr65548, addendum] [5/6 Regression] gfc_conv_procedure_call

[Andre Vehreschild <vehre at gmx dot de>]

Hi Thomas,

thanks for the review. Commited as r223738 with the changes (new testcase,
double space in dg-do).

Regards,
	Andre

On Wed, 27 May 2015 08:38:07 +0200
Thomas Koenig <tkoenig@netcologne.de> wrote:

> Hi Andre,
> 
> > Because this patch is obvious I plan to commit it tomorrow if no one
> > objects?!
> 
> The patch itself is obviously OK.
> 
> About the test case:  In general, it is better not to change existing
> test cases unless absolutely necessary (e.g. adjust an error message).
> This makes it easier to track regressions.
> 
> I would prefer if you made a new test case from your existing one,
> with the changes you did and a small explanation of what was
> tested in the comments.
> 
> If you are worried about runtime for an additonal test, you can use the
> 
> ! { dg-do  run }
> 
> hack (notice the two spaces between the dg-do and the run) to have the
> test case execute only once.
> 
> OK with that change.
> 
> Regards
> 
> 	Thomas
> 


-- 
Andre Vehreschild * Email: vehre ad gmx dot de